TST: adding tests of current clear behavior on ticks #27457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Dec 6, 2023
tacaswell
force-pushed
the
tst/tick_clear_behavior
branch
from
215f053 to
b727ac3
Compare
tacaswell
force-pushed
the
tst/tick_clear_behavior
branch
from
b727ac3 to
dd19976
Compare
timhoffm
reviewed
Dec 7, 2023
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
Adding some comments makes it more clear what the test does and how it works.
Member
|
Ping @tacaswell This is basically good to go. Only minor comments to make the test more understandable. |
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
ksunden
reviewed
Mar 6, 2024
timhoffm
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #23839
This implements the suggestion from @timhoffm in #23806 (comment)