Query macOS for available system fonts.#27230
Merged
dstansby merged 1 commit intomatplotlib:mainfrom Jan 12, 2024
Merged
Conversation
... instead of only relying on a fixed list of directories to check. Note that both previously and with this PR, we continue also querying fontconfig.
Member
|
I did not realize that |
QuLogic
reviewed
Oct 31, 2023
| def _get_macos_fonts(): | ||
| """Cache and list the font paths known to ``system_profiler SPFontsDataType``.""" | ||
| d, = plistlib.loads( | ||
| subprocess.check_output(["system_profiler", "-xml", "SPFontsDataType"])) |
Member
There was a problem hiding this comment.
Is this output portable across different system languages?
Contributor
Author
There was a problem hiding this comment.
From a quick check, the answer appears to be yes.
greglucas
approved these changes
Jan 12, 2024
Contributor
greglucas
left a comment
greglucas
left a comment
There was a problem hiding this comment.
I'll note that system_profiler -xml SPFontsDataType is quite a bit slower than fc-list for me. This does work as expected and is only adding extra time to the initial cache build.
dstansby
approved these changes
Jan 12, 2024
Member
dstansby
left a comment
dstansby
left a comment
There was a problem hiding this comment.
LGTM; doesn't take that long to build the font cache on this PR for me (~seconds on an M2 MacBook Air), and more fonts are found (374 before, 497 after)
|
@anntzer, on my macos 10.15.7 Catalina 💥 200-odd such lines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... instead of only relying on a fixed list of directories to check. Note that both previously and with this PR, we continue also querying fontconfig.
See #10932. This should close the original issue (#10201); for #10932 I would suggest further dropping out the extra hard-coded directories (X11FontDirectories, OSXFontDirectories) that are searched.
PR summary
PR checklist