Use Axes instead of axes core library code #27105
Conversation
ksunden
left a comment
ksunden
left a comment
There was a problem hiding this comment.
Mostly seeps pretty good, a couple that I thought were missed (that I could see in the diff view, did not go digging for more)
And wonder if we should give the same treatment to Figure, at least when in close proximity to the Axes that are affected here, as while there is less room for confusion on that one, treating it different to Axes is slightly jarring.
|
|
||
| fig, axs = plt.subplots(2, 1) | ||
| fig.suptitle('mouse hover over figure or axes to trigger events') | ||
| fig.suptitle('mouse hover over figure or Axes to trigger events') |
There was a problem hiding this comment.
I know the focus was on axes vs Axes, but feels incongruent to leave figure uncapitalized when Axes is capitalized
This was the first place I noticed it (because this was the first line in the diff as rendered on GitHub), but that thought did come up in several other files, notably legend.py and patches.py, and several other places where figures are referred to in the same manner as Axes, but the capitalization is different.
Also this is in galleries, fyi.
There was a problem hiding this comment.
Lower case figure: See #18707 (comment) and the response #18707 (comment)
There was a problem hiding this comment.
The response is that Figure may be figure without ambiguity, not that it must be figure.
timhoffm
force-pushed
the
doc-axes-core
branch
from
8969106 to
245f5fc
Compare
timhoffm
force-pushed
the
doc-axes-core
branch
from
245f5fc to
30a6af3
Compare
6 participants
Part of #18726.