Changing _log.info to warnings.warn and importing the warnings module. #27073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Yeah, they weren't. I thought not a lot of discussion was going to happen, that's why I opened the PR. But I believe opening the PR sparked the discussion again, as it made it more recent and fresh. |
Member
|
Unfortunately, the decision is not conclusive yet. You are right that it stalled, but got revived through this PR 😄 . Let's wait, what #23422 brings. |
timhoffm
added a commit
to timhoffm/matplotlib
that referenced
this pull request
Dec 17, 2025
Closes matplotlib#27073. For details see https://github .com/matplotlib/issues/23422#issuecomment-2363859957.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Changing the _log.info to warnings.warn when passing string-formatted numbers as data, closes #23422 as for now.
PR checklist