Added test_hist in test_datetime.py#27028
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
This seems good. However, can you also check that specifying the bin edges in datetime64 works?
|
Do you want me to do it in a new method or have datetime64 and datetime in the same method? |
|
Sorry I didn't note that you had tested datetime not datetime64. I think testing datetime as the bin edges should be fine. |
|
Is there any other things that I need to do for this PR to be merged? |
|
My original request still stands. Please also test with a list of datetimes as the bin edges in addition to testing bins=10. |
|
Test with a list of datetimes as the bin edges: |
|
Let me know if I am doing it right or if there are any other requirements. Thank you |
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
Thanks! Needs another reviewer, but looks great to me
|
Thank you, congrats on your merged PR, hope to hear from you again! |
4 participants
PR summary
Added test_hist method in test_datetime.py as part of the #26859
PR checklist