Repository navigation
[DOC]: annotation tutorial: blended artist, headers, and user demo deletes - #26445
Merged
Merged
Conversation
rcomer
reviewed
Aug 5, 2023
rcomer
left a comment
Member
There was a problem hiding this comment.
I like this. The layout seems better, and the extra subheadings will make it easier to link to specific things when helping people.
It looks like CI is failing because a whatsnew entry links to the userdemo example.
Does this close #24723?
| t1 = ax.text(0.05, .05, "Anchor 1", va='bottom', ha='left') | ||
| t2 = ax.text(0.90, .90, "Anchor 2", ha='right') | ||
| t3 = ax.annotate("Anchored to 1 & 2", xy=(0, 0), xycoords=(t1, t2), | ||
| va='bottom', color='tab:orange',) |
Member
Author
|
I think it will once I fix the what's new? |
Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
Member
Author
My new documentation philosophy is embrace all subheadings -> also b/c I'm finding that it makes the page so much more skimmable and I think shows up better in search. |
rcomer
approved these changes
Aug 7, 2023
Member
|
Milestoned for 3.8 as any backport would need to be manual (into tutorials). I’m not convinced it’s worth it so close to the release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an example of using two artists in the blended specifications just to make it more clear that's possible. While doing that, I made each of the coordinate types a subsection to make 'em easier to find. I also changed all the subsections to ^ cause that's what we specify in the doc docs.
Also got deleted and redirected the following because they're integrated into the tutorial: