Only do pchanged and set stale when value changes + doc consistency #26326
+30
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
approved these changes
Jul 16, 2023
| self.pchanged() | ||
| self.stale = True |
Contributor
There was a problem hiding this comment.
For a follow-up PR I wonder if we should move self.stale = True into the pchanged definition? It seems like every call to pchanged is followed by self.stale = True...
Member
Author
There was a problem hiding this comment.
That can for sure be a good idea.
oscargus
force-pushed
the
artistprotection
branch
3 times, most recently
from
87098e3 to
76fcf6e
Compare
Member
|
Hmm, most of this seems like it should be in #26334? |
Member
Author
|
Sort of. I stopped adding those here and started a new PR. I can possibly move individual files to that PR instead. |
oscargus
force-pushed
the
artistprotection
branch
from
76fcf6e to
59dbd1e
Compare
Member
Author
|
I moved all files other than artist.py to #26334. |
5 tasks
oscargus
force-pushed
the
artistprotection
branch
from
59dbd1e to
fdcaafc
Compare
oscargus
force-pushed
the
artistprotection
branch
from
fdcaafc to
439cf08
Compare
tacaswell
reviewed
Aug 9, 2023
tacaswell
approved these changes
Aug 9, 2023
Member
|
anyone can merge what green |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
Original purpose was to not call pchanged or set stale to True if the value did not change (some set-methods already do this).
However, I found some doc inconsistencies so did a bit of search-and-replace as well...
PR checklist