Skip to content

Conversation

@QuLogic
Copy link
Member

@QuLogic QuLogic commented Jun 28, 2023

PR summary

The former location was deprecated in 3.7 (#23576), and accidentally removed earlier during some cleanup (#25787).

PR checklist

The former location was deprecated in 3.7, and accidentally removed
earlier during some cleanup.
@QuLogic QuLogic added this to the v3.8.0 milestone Jun 28, 2023
@tacaswell
Copy link
Member

Should he have expected stubtest to have caught this?

@ksunden
Copy link
Member

ksunden commented Jun 28, 2023

No, stubtest won't catch it because it ignores imported names (unless they are in __all__ or have import foo as foo)

I noted it in #25787 as something that pycln did that I wanted to undo, but apparently missed actually undoing it like I did for the mathtext reexports.

@tacaswell tacaswell merged commit 8ad208f into matplotlib:main Jun 29, 2023
@QuLogic QuLogic deleted the textpath-types branch June 29, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants