Skip to content

MNT: py312 deprecates pickling objects in itertools - #26154

Merged
ksunden merged 3 commits into
matplotlib:mainfrom
tacaswell:fix/py312_itertools
Jun 23, 2023
Merged

ksunden merged 3 commits into
matplotlib:mainfrom
tacaswell:fix/py312_itertools

Conversation

@tacaswell

Copy link
Copy Markdown
Member

PR summary

Account for a deprecation in CPython.

PR checklist

  • new and changed code is tested

@tacaswell tacaswell added this to the v3.7.2 milestone Jun 20, 2023
@QuLogic

QuLogic commented Jun 20, 2023

Copy link
Copy Markdown
Member

This came from python/cpython#101588.

However, this doesn't pass for me, I think there might be another case in _process_plot_var_args. Maybe also UnitData and _AxesStack.

@tacaswell

Copy link
Copy Markdown
Member Author

Yeah, not enough (There are some other failures on the CPython main branch coming from pyparsing issues and I missed other related issuses).

@tacaswell tacaswell closed this Jun 20, 2023
@tacaswell tacaswell reopened this Jun 20, 2023
@tacaswell

Copy link
Copy Markdown
Member Author

It looks like the tk issue has spread to GHA as well.

@QuLogic QuLogic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM on Fedora with 3.12 test builds.

@ksunden
ksunden merged commit 1d0d255 into matplotlib:main Jun 23, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jun 23, 2023
QuLogic added a commit that referenced this pull request Jun 23, 2023
…154-on-v3.7.x

Backport PR #26154 on branch v3.7.x (MNT: py312 deprecates pickling objects in itertools)
@tacaswell
tacaswell deleted the fix/py312_itertools branch June 27, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants