Repository navigation
Cleanup AxesGrid - #26036
Merged
Merged
Cleanup AxesGrid#26036
Conversation
- Simplify AxesGrid._init_locators.
- Simplify label on/off logic in AxesGrid:
* Inline _tick_only to its only calling method. Also note that the
kwargs to tick_only were previously named somewhat strangely
(bottom_on = "turn off the bottom ticklabels and label", ditto for
left_on).
* Simplify the condition checks for "L" mode (left only on for the
first column, bottom only on for the last row).
tacaswell
approved these changes
Jun 1, 2023
timhoffm
approved these changes
Jun 2, 2023
QuLogic
reviewed
Jun 2, 2023
| col, row = self._get_col_row(i) | ||
| locator = self._divider.new_locator( | ||
| nx=h_ax_pos[col], ny=v_ax_pos[self._nrows - 1 - row]) | ||
| nx=h_indices[col], ny=v_indices[self._nrows - 1 - row]) |
Member
There was a problem hiding this comment.
Doesn't this just work out to:
Suggested change
| nx=h_indices[col], ny=v_indices[self._nrows - 1 - row]) | |
| nx=col * 2, ny=(self._nrows - 1 - row) * 2) |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify AxesGrid._init_locators.
Simplify label on/off logic in AxesGrid:
followup to #26020
PR summary
PR checklist