Repository navigation
test annotate(textcoords=offset fontsize) - #25989
Merged
Merged
Conversation
anntzer
reviewed
May 27, 2023
| if i == 0: | ||
| points_coords = str(ann.get_window_extent()) | ||
| else: | ||
| fontsize_coords = str(ann.get_window_extent()) |
Contributor
There was a problem hiding this comment.
would spell the whole thing
anns = [ax.annotate(...) for i in ...]
point_coords, fontsize_coords = [ann.get_window_extent() for ann in anns]
assert str(point_coords) == str(fontsize_coords)but either way works.
Contributor
Author
There was a problem hiding this comment.
If you're happy with that, I'll squash it down 👍
anntzer
approved these changes
May 27, 2023
rcomer
approved these changes
May 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
PR checklist
Closes #25907. Adds a test to check that the annotation
offset_fontsizeparameter actually offsets the text by the correct fontsize units. The unit distance was measured by comparing the fontsize against the number of points inoffset_points