Skip to content

Upload nightlies to new location - #25950

Merged
QuLogic merged 1 commit into
matplotlib:mainfrom
jarrodmillman:nightlies
Jun 1, 2023
Merged

Upload nightlies to new location#25950
QuLogic merged 1 commit into
matplotlib:mainfrom
jarrodmillman:nightlies

Conversation

@jarrodmillman

@jarrodmillman jarrodmillman commented May 22, 2023

Copy link
Copy Markdown
Contributor

PR summary

PR checklist

@jarrodmillman
jarrodmillman marked this pull request as draft May 22, 2023 17:41
@jarrodmillman jarrodmillman mentioned this pull request May 22, 2023
Merged
5 tasks
@martinfleis

martinfleis commented May 23, 2023

Copy link
Copy Markdown

A bit of context - the Scientific Python Developer Summit is happening this week. A part of the effort is to ensure that Scientific Python core packages follow the upcoming SPEC documents and support their implementation across the ecosystem. One of the specific changes is a move of the nightly wheels from pypi.anaconda.org/scipy-wheels-nightly which is planned to be closed to pypi.anaconda.org/scientific-python-nightly-wheels. That is what this PR does.

Once all of the packages that currently use scipy-wheels-nightly switch to scientific-python-nightly-wheels, we will use a bot to open PRs in downstream repositories to automatically change the index for nightlies across the ecosystem to minimise breakage.

One more step will need to happen here though. The upload requires an upload token stored as a repository secret (as you have right now). However, you will need to generate a new token for the new anaconda organisation. @ksunden will take care of that.

The same change is happening in the other packages as well.

@tacaswell tacaswell added this to the v3.8.0 milestone May 24, 2023
@pllim pllim mentioned this pull request May 25, 2023
Merged
@ksunden ksunden mentioned this pull request May 26, 2023
Merged
5 tasks
@jarrodmillman
jarrodmillman marked this pull request as ready for review May 26, 2023 18:52
@matthewfeickert matthewfeickert mentioned this pull request May 26, 2023
Closed
matthewfeickert
matthewfeickert reviewed May 27, 2023
View reviewed changes
Comment thread .github/workflows/nightlies.yml
QuLogic
QuLogic requested changes May 27, 2023
View reviewed changes

@QuLogic QuLogic left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the typo.

@rcomer

rcomer commented May 29, 2023

Copy link
Copy Markdown
Member

We will also need to update the docs here, but I leave it to others to decide whether that should be in this PR or a follow-up.
https://matplotlib.org/stable/users/installing/index.html#installing-a-nightly-build

@matthewfeickert matthewfeickert mentioned this pull request May 30, 2023
Merged
1 task
@matthewfeickert

matthewfeickert commented May 30, 2023

Copy link
Copy Markdown
Contributor

We will also need to update the docs here, but I leave it to others to decide whether that should be in this PR or a follow-up. https://matplotlib.org/stable/users/installing/index.html#installing-a-nightly-build

@rcomer I already had this ready to go on a branch in my fork, so I just rebased it to open up PR #26006. (If people want to do it all in one go here, feel free to close mine.)

I also have a branch with my earlier comment #25950 (review) ready to PR.

@jarrodmillman

jarrodmillman commented May 31, 2023

Copy link
Copy Markdown
Contributor Author

Please fix the typo.

@QuLogic Did this get fixed? If not, what typo are you referring to?

@ksunden ksunden changed the title Upload nighlighties to new location Upload nightlies to new location May 31, 2023
@matthewfeickert

matthewfeickert commented May 31, 2023

Copy link
Copy Markdown
Contributor

Please fix the typo.

@QuLogic Did this get fixed? If not, what typo are you referring to?

@jarrodmillman Not sure if this is what was meant, but there's the typo in the commit message itself: "Upload nighlighties to new location"

@QuLogic

QuLogic commented May 31, 2023

Copy link
Copy Markdown
Member

Please fix the typo.

@QuLogic Did this get fixed? If not, what typo are you referring to?

@jarrodmillman Not sure if this is what was meant, but there's the typo in the commit message itself: "Upload nighlighties to new location"

Yes, as noted for all these PRs scientific-python/specs#182 (comment)

@matthewfeickert matthewfeickert mentioned this pull request May 31, 2023
Merged
4 tasks
matthewfeickert added a commit to scikit-hep/mplhep that referenced this pull request May 31, 2023
@matthewfeickert
ci: Use scientific-python-nightly-wheels for dependency nightlies
cc50d05 
* Nightly wheels for the Scientific Python community have migrated from
  the Anaconda Cloud https://anaconda.org/scipy-wheels-nightly/ package
  index to https://anaconda.org/scientific-python-nightly-wheels.
   - c.f. https://scientific-python.org/specs/spec-0004/
   - c.f. scientific-python/specs#182
   - c.f. matplotlib/matplotlib#25950
* For matplotlib use --index-url of scientific-python-nightly-wheels and
  use --extra-index-url of public PyPI (https://pypi.org/) as some of
  matplotlib's dependencies aren't on scientific-python-nightly-wheels.
matthewfeickert added a commit to scikit-hep/pyhf that referenced this pull request May 31, 2023
@matthewfeickert
ci: Use scientific-python-nightly-wheels package index for dependency…
afba6da 
… nightlies (#2225)

* Nightly wheels for the Scientific Python community have migrated from
  the Anaconda Cloud https://anaconda.org/scipy-wheels-nightly/ package
  index to https://anaconda.org/scientific-python-nightly-wheels.
   - c.f. https://scientific-python.org/specs/spec-0004/
   - c.f. scientific-python/specs#182
   - c.f. matplotlib/matplotlib#25950
* For matplotlib use --index-url of scientific-python-nightly-wheels and
  use --extra-index-url of public PyPI (https://pypi.org/) as some of
  matplotlib's dependencies aren't on scientific-python-nightly-wheels.
@matthewfeickert matthewfeickert mentioned this pull request May 31, 2023
Merged
@jarrodmillman

jarrodmillman commented May 31, 2023

Copy link
Copy Markdown
Contributor Author

Typo fixed.

@QuLogic
QuLogic merged commit bfaa6eb into matplotlib:main Jun 1, 2023
@matthewfeickert matthewfeickert mentioned this pull request Jun 1, 2023
Merged
@ksunden ksunden mentioned this pull request Jun 12, 2023
Merged
ksunden added a commit to ksunden/matplotlib that referenced this pull request Jun 12, 2023
@ksunden
[MNT] Update nightly wheels install location
f20bca8 
I had originally thought this was included in matplotlib#25950 (hence why I had waited so long to merge it...), but apparently it was not.

Now that both pandas and numpy are uploading to the new location, this is the expected install location for new nightlies
melissawm pushed a commit to melissawm/matplotlib that referenced this pull request Jun 15, 2023
@ksunden @melissawm
[MNT] Update nightly wheels install location
e5bd5b2 
I had originally thought this was included in matplotlib#25950 (hence why I had waited so long to merge it...), but apparently it was not.

Now that both pandas and numpy are uploading to the new location, this is the expected install location for new nightlies
andrzejnovak pushed a commit to scikit-hep/mplhep that referenced this pull request Jul 10, 2023
@matthewfeickert
ci: Use scientific-python-nightly-wheels for dependency nightlies (#430)
9b47e92 
* Nightly wheels for the Scientific Python community have migrated from
  the Anaconda Cloud https://anaconda.org/scipy-wheels-nightly/ package
  index to https://anaconda.org/scientific-python-nightly-wheels.
   - c.f. https://scientific-python.org/specs/spec-0004/
   - c.f. scientific-python/specs#182
   - c.f. matplotlib/matplotlib#25950
* For matplotlib use --index-url of scientific-python-nightly-wheels and
  use --extra-index-url of public PyPI (https://pypi.org/) as some of
  matplotlib's dependencies aren't on scientific-python-nightly-wheels.
jonas-eschle pushed a commit to scikit-hep/mplhep that referenced this pull request Apr 22, 2024
@matthewfeickert @jonas-eschle
ci: Use scientific-python-nightly-wheels for dependency nightlies (#430)
8f1dbb7 
* Nightly wheels for the Scientific Python community have migrated from
  the Anaconda Cloud https://anaconda.org/scipy-wheels-nightly/ package
  index to https://anaconda.org/scientific-python-nightly-wheels.
   - c.f. https://scientific-python.org/specs/spec-0004/
   - c.f. scientific-python/specs#182
   - c.f. matplotlib/matplotlib#25950
* For matplotlib use --index-url of scientific-python-nightly-wheels and
  use --extra-index-url of public PyPI (https://pypi.org/) as some of
  matplotlib's dependencies aren't on scientific-python-nightly-wheels.
@mattip

mattip commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

Hi all. I see files at https://anaconda.org/scipy-wheels-nightly/matplotlib. May I delete them? The last upload to there was June 1, 2023.

@matthewfeickert

matthewfeickert commented Dec 3, 2025

Copy link
Copy Markdown
Contributor

@QuLogic should be the one to comment, but Matplotlib has been uploading nightlies to https://anaconda.org/channels/scientific-python-nightly-wheels/packages/matplotlib/overview for a long time, so I would assume that would be fine.

@tacaswell

tacaswell commented Dec 3, 2025

Copy link
Copy Markdown
Member

@mattip Yes.

@mattip

mattip commented Dec 4, 2025

Copy link
Copy Markdown
Contributor

Deleted, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes
@QuLogic QuLogic QuLogic approved these changes
+1 more reviewer
@matthewfeickert matthewfeickert matthewfeickert left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.8.0

Development

Successfully merging this pull request may close these issues.

7 participants

@jarrodmillman @martinfleis @rcomer @matthewfeickert @QuLogic @mattip @tacaswell