migrate from utcfromtimestamp to fromtimestamp#25918
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
Thank you! I think it will be solved if you change order of the imports and change (I take it that you edit in the browser? We should just remember to squeeze it down into one single commit when merging.) |
ahh makes sense |
|
You also need to import timezone before datetime. |
oscargus
left a comment
oscargus
left a comment
There was a problem hiding this comment.
Thanks!
Note to second reviewer/merger: make sure you squash the commits before merging.
|
Thank you for this @smeet07 and congratulations on your first merged Matplotlib PR 🎉 I hope we hear from you again! |
|
@meeseeksdev backport to v3.7.x |
…918-on-v3.7.x Backport PR #25918 on branch v3.7.x (migrate from utcfromtimestamp to fromtimestamp)
4 participants
PR summary
utcfromtimestamp is getting deprecated, making appropriate changes to avoid behavior changes
PR checklist
closes #25912