Skip to content

MNT: update Shadow init signature - #25872

Merged
tacaswell merged 1 commit into
matplotlib:mainfrom
tacaswell:fix_mypy_shade
May 12, 2023
Merged

tacaswell merged 1 commit into
matplotlib:mainfrom
tacaswell:fix_mypy_shade

Conversation

@tacaswell

Copy link
Copy Markdown
Member

PR summary

Fixes typing bug from me merging #25389

The CI on that PR was from before we merge the typing so this was not checked.

@tacaswell tacaswell added this to the v3.8.0 milestone May 12, 2023
Comment thread lib/matplotlib/patches.pyi Resolved
Comment thread lib/matplotlib/patches.pyi Resolved
Comment thread lib/matplotlib/patches.pyi Resolved

@rcomer rcomer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It passes 🥳

@tacaswell

Copy link
Copy Markdown
Member Author

I'm going to squash this down to one commit and we can not talk about the amount of tries it took .....

Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
@tacaswell

Copy link
Copy Markdown
Member Author

This has passed mypy and the stubs should not be used any where else so I'm going to merge before all of CI is done to un-break CI for all other PRs.

@tacaswell
tacaswell merged commit 072e8f3 into matplotlib:main May 12, 2023
@tacaswell
tacaswell deleted the fix_mypy_shade branch May 12, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants