Repository navigation
Conversation
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Contributor
QuLogic
requested changes
May 10, 2023
QuLogic
left a comment
QuLogic
left a comment
Member
There was a problem hiding this comment.
We would prefer if you could rebase instead of merge. It appears there are some completely unrelated commits in this PR that shouldn't be here.
| # If a 2D collection was passed, it has been converted to 3D | ||
|
|
||
| if autolim: | ||
| if type(col) is art3d.Line3DCollection: |
Member
There was a problem hiding this comment.
Is there a reason to not use isinstance here?
Contributor
|
Hi @lganic, are you still interested in working on this PR? |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
closes #17130
Adds support for auto-scaling 3D collection objects in the add_collection3d function. The new implementation is consistent with the behavior of the existing 2D implementation, where auto-scaling is True by default.
Test cases were added for each of the relevant autoscaling functions.
The autoscaling works with most 2D/3D collections; the only collection I wasn't able to get working was Patch3DCollection, which (as far as I can tell) seems to have a number of ongoing bugs that make them borderline unusable, and untestable.
Also turns out that a few of the test cases suffered from the bug seen in #17130, so I updated the failing tests accordingly.
PR Checklist
Linked Issue
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst