Skip to content

MNT: optionally collect gc in memleak.py #25500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
richardsheridan wants to merge 1 commit into from
Closed

MNT: optionally collect gc in memleak.py #25500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions tools/memleak.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import numpy as np


def run_memleak_test(bench, iterations, report):
def run_memleak_test(bench, iterations, report, collect):
tracemalloc.start()

starti = min(50, iterations // 2)
Expand All @@ -31,7 +31,8 @@ def run_memleak_test(bench, iterations, report):
for i in range(endi):
bench()

gc.collect()
if collect:
gc.collect()

rss = p.memory_info().rss
malloc, peak = tracemalloc.get_traced_memory()
Expand Down Expand Up @@ -135,6 +136,8 @@ def __call__(self):
parser.add_argument('--interactive', action='store_true',
help="Turn on interactive mode to actually open "
"windows. Only works with some GUI backends.")
parser.add_argument('--gc-collect', action='store_true',
help="Run `gc.collect()` after every iteration")

args = parser.parse_args()

Expand All @@ -146,4 +149,4 @@ def __call__(self):
plt.ion()

run_memleak_test(
MemleakTest(args.empty), args.iterations[0], args.report[0])
MemleakTest(args.empty), args.iterations[0], args.report[0], args.gc_collect)