Repository navigation
Adjust parent axes limits when clearing floating axes. - #25444
Merged
Merged
Conversation
Without this patch, calling clear() in a FloatingAxes will reset the limits of the (invisible, parent, rectilinear) axes to (0, 1), (0, 1), instead of the values computed by adjust_axes_lim. For example, try adding a call to ax1.clear() in demo_floating_axes immediately after the call to setup_axes1.
oscargus
approved these changes
Mar 13, 2023
timhoffm
approved these changes
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this patch, calling clear() in a FloatingAxes will reset the limits of the (invisible, parent, rectilinear) axes to (0, 1), (0, 1), instead of the values computed by adjust_axes_lim. For example, try adding a call to ax1.clear() in demo_floating_axes immediately after the call to setup_axes1; this previously resulted in a blown up left axes.
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst