Repository navigation
Store FloatingAxes "extremes" info in fewer places. - #25427
Merged
Merged
Conversation
anntzer
force-pushed
the
unex
branch
2 times, most recently
from
March 10, 2023 12:43
f321161 to
3098161
Compare
greglucas
approved these changes
Mar 11, 2023
| @@ -0,0 +1,3 @@ | |||
| ``GridHelperCurveLinear.get_data_boundary`` | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
| ... is deprecated with no replacement. | |||
Contributor
There was a problem hiding this comment.
Do we want a note about how one can do this still? (at least pointing someone in the right direction even if it isn't a direct replacement)
Use grid_finder.extreme_finder(*[None] * 5) to get the extremes of the grid.
Make the value returned by ExtremeFinderFixed be the canonical place to query the value of the extremes parameter. This may make it easier to change the extremes post-facto (there's fewer places to update). Also deprecate the related get_data_boundary method, which doesn't exist anywhere else and isn't really needed as a separate API: we can just inline it into its only call site instead.
oscargus
approved these changes
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the value returned by ExtremeFinderFixed be the canonical place to query the value of the extremes parameter.
This may make it easier to change the extremes post-facto (there's fewer places to update): #25426. (Though some further work is needed...)
Also deprecate the related get_data_boundary method, which doesn't exist anywhere else and isn't really needed as a separate API: we can just inline it into its only call site instead.
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst