Repository navigation
CI: Pin reviewdog eslint to use node 18.13 - #25262
Merged
Merged
Conversation
The reviewdog action is not compatible with npm v9 yet, and node 18.14+ comes with npm v9+.
greglucas
force-pushed
the
ci-reviewdog-eslint
branch
from
February 19, 2023 20:30
f0094dc to
88d109f
Compare
jklymak
approved these changes
Feb 19, 2023
rcomer
approved these changes
Feb 20, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 20, 2023
rcomer
added a commit
that referenced
this pull request
Feb 20, 2023
…262-on-v3.7.x Backport PR #25262 on branch v3.7.x (CI: Pin reviewdog eslint to use node 18.13)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The reviewdog action is not compatible with npm v9 yet, and node 18.14+ comes with npm v9+.
closes #25251
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst