Skip to content

Fix lasso unresponsive issue by adding a lock release event - #25155

Merged
QuLogic merged 4 commits into
matplotlib:mainfrom
devRD:lasso_demo
Feb 22, 2023
Merged

QuLogic merged 4 commits into
matplotlib:mainfrom
devRD:lasso_demo

Conversation

@devRD

@devRD devRD commented Feb 5, 2023

Copy link
Copy Markdown
Contributor

PR Summary

Fixes #25137 by adding a lock release event.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

@jklymak

jklymak commented Feb 14, 2023

Copy link
Copy Markdown
Member

@ianhi maybe you are the wrong person to ask for a review here, but feel free to suggest someone else...

@ianhi ianhi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd approve this (conditional on my comment about checking for ownership of the lock) as this does indeed fix the reported bug. Nice fix @devRD!

That said I think that using Lasso is something that should be discouraged in favor of lasso selector - perhaps even deprecated and removed. See my comments in #19221 for more. Still this is clear improvement and the perfect should not be the enemy of the good.

@ianhi maybe you are the wrong person to ask for a review here,

I'm probably the right person :)

Comment thread examples/event_handling/lasso_demo.py Resolved
Co-authored-by: Ian Hunt-Isaak <ianhuntisaak@gmail.com>
@devRD

devRD commented Feb 16, 2023

Copy link
Copy Markdown
Contributor Author

@ianhi Thank you for the review! I added your suggested changes.

@ianhi

ianhi commented Feb 16, 2023

Copy link
Copy Markdown
Contributor

Awesome @devRD - i think that the process is now that at least one core dev (i.e. not me) needs to approve this (only one as this is documentation).

For whoever that is I think the things to check are:

  1. Run the example - click once, then see that you can still lasso as expected
  2. Run the example make lassos as expected

full file for copy paste purposes: https://github.com/matplotlib/matplotlib/blob/418c9e7037896bea4a4db5cce656f2933014f0e0/examples/event_handling/lasso_demo.py

@jklymak

jklymak commented Feb 16, 2023

Copy link
Copy Markdown
Member

@ianhi you have merge rights, if I'm not mistaken.

@ianhi

ianhi commented Feb 16, 2023

Copy link
Copy Markdown
Contributor

@ianhi you have merge rights, if I'm not mistaken.

I actually don't - I think I only have the power to open/close issues+PRs and apply labels. I have merging rights over on ipympl

Comment thread examples/event_handling/lasso_demo.py Resolved
@QuLogic QuLogic mentioned this pull request Feb 22, 2023
Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@QuLogic QuLogic added this to the v3.7.1 milestone Feb 22, 2023
@QuLogic
QuLogic merged commit 1163b30 into matplotlib:main Feb 22, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Feb 22, 2023
@QuLogic

QuLogic commented Feb 22, 2023

Copy link
Copy Markdown
Member

Thanks @devRD! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

ksunden added a commit that referenced this pull request Feb 23, 2023
…155-on-v3.7.x

Backport PR #25155 on branch v3.7.x (Fix lasso unresponsive issue by adding a lock release event)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

[Bug]: stop responding in demo program "matplotlib/examples/event_handling/lasso_demo.py"

6 participants