-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Stop recommending ncol in legend examples
#25110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Since 958e329 the preferred keyword for controlling the number of columns in a legend is `ncols`, but some code examples have still been using `ncol`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
rcomer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @eerovaher! I think we just need to wait for the CI to pass…
ksunden
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rerunning tests which failed for seemingly unrelated reasons (macos subprocess timeout, though test_blit, not the most common test_interactive)
Anyone can merge on green CI
…110-on-v3.7.x Backport PR #25110 on branch v3.7.x (Stop recommending `ncol` in legend examples)
|
Thank you for submitting your first PR to Matplotlib @eerovaher. We hope to hear from you again. |
PR Summary
Since 958e329 the preferred keyword for controlling the number of columns in a legend is
ncols. However,reveals several uses of the old keyword. This pull request replaces most of them with the new recommended
ncols, but three uses ofncolshould remain in place:matplotlib/doc/users/prev_whats_new/whats_new_0.98.4.rst
Line 40 in a30c0b1
matplotlib/lib/matplotlib/legend.py
Line 383 in a30c0b1
matplotlib/lib/matplotlib/tests/test_legend.py
Line 1220 in a30c0b1
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst