Repository navigation
Conversation
|
Hmmm, I think my vote would be to fix FancyArrowPatch. Although, I have to |
There was a problem hiding this comment.
Use the matplotlib deprecation warning (I think it is in cbook)
There was a problem hiding this comment.
Actually, it is less a deprecation, more an outright removal, so I'd consider raising an Exception (others - does that fit with how you would do things here?)
|
@tonysyu Where does this stand? In any case it needs a re-base again. |
|
@tacaswell Thanks for bumping the PR. I'm not really sure where this stands, though. I submitted this PR to get feedback about some of the design decisions, but I don't think I'm any closer to reaching a conclusion. In retrospect, I think I really don't like breaking the API and replacing |
|
Closing until @tonysyu is happy with the PR. |
Currently,
streamplotreturns a not-so-usefulStreamplotSetcontaining the line and arrow collections drawn on the figure. One major problem was that the arrow collection created was never added to the axes (each arrow patch was added separately). Unfortunately, making the arrows a truePatchCollectionis a bit difficult:FancyArrowPatchdoesn't seem to play nice withPatchCollection.To fix these issues this PR:
FancyArrowinstead ofFancyArrowPatchStreamplotSetaCompositeCollection.The consequences are that:
arrowstyleneeds to be deprecated as an argument tostreamplotCompositeCollectionmay be a bit too magical (it automatically delegates attribute access to sub-collections)Alternatives:
FancyArrowPatchto work withPatchCollection. This probably requires some transform knowledge that I'm missing.CompositeCollection, just add some subset of collection methods/attrs that the set should support.Note: Changes to
pyplot.pywere generated byboilerplate.py.