Expire deprecations from 3.6#24984
Conversation
oscargus
force-pushed
the
pickradius
branch
4 times, most recently
from
dbb0c54 to
f97e5f5
Compare
| ax_bottom.set_ylim(0, .75) | ||
| ax_bottom.add_artist(mpatches.Rectangle(grid[1] - [0.025, 0.05], | ||
| 0.05, 0.1)) | ||
| ax_bottom.add_artist(mpatches.RegularPolygon(grid[3], 5, 0.1)) |
There was a problem hiding this comment.
One would have expected this to warn earlier?
Edit: it did warn, but it seems like the doc-build didn't pick it up.
|
Thank you for doing this. I read through the file diffs without finding any problems. I did not try to match every removal with a note in the changes/removals file, but I did notice that removals from the backends don't seem to be mentioned there. |
|
Ahh, you are correct. Well spotted! In the 3.6 documents it was a big list of all the backend changes, but I didn't touch the interactive ones, so at the time I just skipped that for later and forgot about it... |
|
This is now added. Note that some of the things didn't have deprecation notices in the 3.6 docs, such as positional argument renaming. |
|
Thanks @anntzer ! Should be sorted out now. |
ksunden
left a comment
ksunden
left a comment
There was a problem hiding this comment.
Only hard blocker is the offsetbox kw-only arg position, but also commented on collections version of pickradius if you wish to make that consistent with some other pickradus implementations
|
Thanks @ksunden ! Good finds! |
4 participants
PR Summary
Not all, but most (all?) of the ones I understood (quite) easily...
Split into multiple commits for somewhat sensible commit messages. Will add an api-change note.
The first commit also improves the argument checking of
(set_)pickradiusslightly.PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst