Skip to content

Support masked dates #24734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rcomer merged 1 commit into from
Dec 16, 2022
Merged

Support masked dates #24734

rcomer merged 1 commit into from
Dec 16, 2022

Conversation

@oscargus
Copy link
Member

@oscargus oscargus commented Dec 15, 2022

PR Summary

Related to #24732 (comment)

Now, date2num does not strip any mask information.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@oscargus oscargus marked this pull request as ready for review December 15, 2022 15:10
@oscargus oscargus mentioned this pull request Dec 15, 2022
Merged
6 tasks
chahak13
chahak13 reviewed Dec 15, 2022
View reviewed changes
rcomer
rcomer reviewed Dec 15, 2022
View reviewed changes
@oscargus oscargus marked this pull request as draft December 15, 2022 16:14
chahak13
chahak13 reviewed Dec 15, 2022
View reviewed changes
@oscargus
Copy link
Member Author

oscargus commented Dec 15, 2022

Thanks for your good reviews @rcomer and @chahak13 !

I came up with a slightly different solution as astimezone didn't exist for MaskedConstant. Now, both paths are tested using masked dates.

@oscargus oscargus marked this pull request as ready for review December 15, 2022 20:55
@oscargus oscargus added this to the v3.7.0 milestone Dec 15, 2022
@oscargus oscargus mentioned this pull request Dec 15, 2022
Open
@rcomer rcomer merged commit 60dd992 into matplotlib:main Dec 16, 2022
@oscargus oscargus deleted the maskeddates branch December 16, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jklymak jklymak jklymak approved these changes

@rcomer rcomer rcomer approved these changes

+1 more reviewer

@chahak13 chahak13 chahak13 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic: date handling topic: units and array ducktypes

Projects

None yet

Milestone

v3.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@oscargus @jklymak @rcomer @chahak13