Skip to content

Init axes._children early enough to avoid need for some getattr calls. #24634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ksunden merged 1 commit into from
Dec 6, 2022
Merged

Init axes._children early enough to avoid need for some getattr calls. #24634

ksunden merged 1 commit into from
Dec 6, 2022

Conversation

@anntzer
Copy link
Contributor

@anntzer anntzer commented Dec 5, 2022

PR Summary

See discussion at #24627 (comment).

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@tacaswell tacaswell added this to the v3.7.0 milestone Dec 6, 2022
tacaswell
tacaswell approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was not as bad as I feared it would be.

@ksunden ksunden merged commit 9d22ab0 into matplotlib:main Dec 6, 2022
@QuLogic QuLogic mentioned this pull request Dec 6, 2022
Merged
1 task
@anntzer anntzer deleted the ac branch December 6, 2022 06:54
rcomer pushed a commit to rcomer/matplotlib that referenced this pull request Dec 10, 2022
@ksunden @rcomer
Backport PR matplotlib#24654: Don't manually invalidate cached lines …
8d8d3f5 
…in _update_transScale

Manual backport required due to simple conflict caused by the
first removed line being different in main and v3.6.x, having
previously been modified at matplotlib#24634.
@rcomer rcomer mentioned this pull request Dec 10, 2022
Merged
6 tasks
@ksunden ksunden mentioned this pull request Feb 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tacaswell tacaswell tacaswell approved these changes

@ksunden ksunden ksunden approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@anntzer @tacaswell @ksunden