FIX: do not use deprecated API in gtk4 backend #24606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixed #24602 for me. Thanks for the quick fix! |
Member
Author
|
Thanks for testing @carmaza ! |
timhoffm
approved these changes
Dec 4, 2022
oscargus
approved these changes
Dec 4, 2022
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
tacaswell
pushed a commit
to tacaswell/matplotlib
that referenced
this pull request
Dec 4, 2022
…backend Merge pull request matplotlib#24606 from tacaswell/fix_gtk_closevent FIX: do not use deprecated API in gtk4 backend (cherry picked from commit 0aac9f1)
oscargus
added a commit
that referenced
this pull request
Dec 5, 2022
…-v3.6.x Backport PR #24606: FIX: do not use deprecated API in gtk4 backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #24602
We do not currently test gtk4 on CI (see #22389)