Skip to content

Conversation

@oscargus
Copy link
Member

PR Summary

It may be that imin is never assigned. All other variables that are in the same if-clause have default values, so an option is to remove all those if we are sure that they will always be assigned a value. But probably safer to provide a default value for imin.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (and pytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

@ksunden ksunden added this to the v3.6.3 milestone Nov 21, 2022
@timhoffm timhoffm merged commit f1e5de1 into matplotlib:main Nov 21, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 21, 2022
QuLogic added a commit that referenced this pull request Nov 22, 2022
…514-on-v3.6.x

Backport PR #24514 on branch v3.6.x (Fix potential issue in contour)
@oscargus oscargus deleted the contourfix branch November 22, 2022 07:42
@ksunden ksunden mentioned this pull request Feb 20, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants