Backport of PR#24488 (Update for pydata-sphinx-theme 0.12.0) #24506
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pydata-sphinx-theme` updated, renaming some configuration names. (only one of which we actually configure) While they are just warnings for now, we are configured to error on warning so CircleCI is indicating failure. This does the 'easy' route of just changing to the new name and expecting the version in which it is implemented. If desired, I could do a larger change to accomodate both by checking the version, but I'm also not _too_ worried about more tightly pinning already relatively tight requirements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
pydata-sphinx-themeupdated, renaming some configuration names. (only one of which we actually configure)While they are just warnings for now, we are configured to error on warning so CircleCI is indicating failure.
This does the 'easy' route of just changing to the new name and expecting the version in which it is implemented.
If desired, I could do a larger change to accomodate both by checking the version, but I'm also not too worried about more tightly pinning already relatively tight requirements.
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst