Skip to content

Conversation

@rifatrakib
Copy link
Contributor

  • removed unused variable lines in line 169
  • should be create custom classes, not custom objects

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a .. versionadded:: directive in the docstring and documented in doc/users/next_whats_new/
  • API changes are marked with a .. versionchanged:: directive in the docstring and documented in doc/api/next_api_changes/
  • Release notes conform with instructions in next_whats_new/README.rst or next_api_changes/README.rst

* removed  unused variable `lines` in line 169
* we create custom classes, not custom objects
@timhoffm timhoffm added this to the v3.6.3 milestone Nov 15, 2022
@timhoffm timhoffm merged commit 90617dd into matplotlib:main Nov 15, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Nov 15, 2022
timhoffm added a commit that referenced this pull request Nov 15, 2022
…459-on-v3.6.x

Backport PR #24459 on branch v3.6.x (removed unused variable and fixed text in doc)
@ksunden ksunden mentioned this pull request Feb 20, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants