Skip to content

Conversation

@NRaudseps
Copy link
Contributor

PR Summary

Hi, I just started with open source and this is my first PR. Noticed some types in the documentation and fixed them.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure the first sentence needs the by but unability->inability is correct

@QuLogic QuLogic merged commit dad3ae3 into matplotlib:main Oct 12, 2022
@QuLogic
Copy link
Member

QuLogic commented Oct 12, 2022

Thanks @NRaudseps! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

@QuLogic QuLogic added this to the v3.7.0 milestone Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants