Skip to content

Expire cursor-related deprecations #24129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuLogic merged 1 commit into from
Oct 17, 2022
Merged

Expire cursor-related deprecations #24129

QuLogic merged 1 commit into from
Oct 17, 2022

Conversation

@oscargus
Copy link
Member

@oscargus oscargus commented Oct 8, 2022

PR Summary

It didn't look like cursord was deprecated in Qt, despite https://matplotlib.org/stable/api/prev_api_changes/api_changes_3.5.0.html#cursord-in-gtk-qt-and-wx-backends

matplotlib/lib/matplotlib/backends/backend_qt.py

Lines 82 to 92 in 924e210

cursord = {
k: getattr(_enum("QtCore.Qt.CursorShape"), v) for k, v in [
(cursors.MOVE, "SizeAllCursor"),
(cursors.HAND, "PointingHandCursor"),
(cursors.POINTER, "ArrowCursor"),
(cursors.SELECT_REGION, "CrossCursor"),
(cursors.WAIT, "WaitCursor"),
(cursors.RESIZE_HORIZONTAL, "SizeHorCursor"),
(cursors.RESIZE_VERTICAL, "SizeVerCursor"),
]
}

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus added this to the v3.7.0 milestone Oct 8, 2022
QuLogic
QuLogic reviewed Oct 12, 2022
View reviewed changes
@oscargus oscargus force-pushed the cursorremovals branch 2 times, most recently from 95ff1f8 to adc305c Compare October 15, 2022 10:17
@QuLogic QuLogic merged commit b7db7c9 into matplotlib:main Oct 17, 2022
@oscargus oscargus deleted the cursorremovals branch October 18, 2022 06:52
@QuLogic QuLogic mentioned this pull request Jan 13, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

API: changes topic: widgets/UI

Projects

None yet

Milestone

v3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oscargus @QuLogic @timhoffm