Skip to content

Conversation

@emmamastro
Copy link

PR Summary

This is in response to Labels for PatchCollection Issue #23998. I added both the Handler for Patch collection class and the patch collection handler to the default_handler_map.

PR Checklist

Tests and Styling

  • [N/A ] Has pytest style unit tests (and pytest passes).
  • [N/A ] Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [ N/A] New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus linked an issue Sep 29, 2022 that may be closed by this pull request
@oscargus
Copy link
Member

oscargus commented Sep 29, 2022

Thanks you! As you noted in #23998 there was already another PR opened. It is not clear which will be merged (although most likely we go with the first if that gets up to shape), but in case you want to complete this one, what is additionally required is a test. This is discussed further in #24028 as it is missing there as well.

Also, there are a number of linting failures.

Finally, in general we prefer to not merge the main branch into a PR, but to rebase the PR onto the main branch. In your case you can do something like (in your branch emma's-branch)

git rebase -i main
# An editor will pop up, remove the line with the merge, save and close
git log
# Confirm that you only have the two commits with your changes as the two last ones
git push origin emma's-branch --force-with-lease

(You can also use git rebase -i main and select fixup to get the number of commits down, usually a single commit is preferred/enough for a PR.)

Edit: note that you probably do not want to fixup the merge commit as that may completely break things.

@jklymak
Copy link
Member

jklymak commented Jan 26, 2023

I'll close this as a duplicate. Please work in the context of the original PR. Thanks for your contribution!

@jklymak jklymak closed this Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Labels for PatchCollection do not show

4 participants