Skip to content

Move axes_grid tests to axes_grid1 #23861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
timhoffm merged 1 commit into from
Sep 13, 2022
Merged

Move axes_grid tests to axes_grid1 #23861

timhoffm merged 1 commit into from
Sep 13, 2022
+50 −56

Conversation

@oscargus
Copy link
Member

@oscargus oscargus commented Sep 11, 2022

PR Summary

axes_grid was deprecated long time ago and finally removed in 3.6. There were some tests residing in test_axes_grid.py that are now moved to test_axes_grid1.py.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@timhoffm timhoffm added this to the v3.7.0 milestone Sep 13, 2022
@timhoffm timhoffm merged commit de98877 into matplotlib:main Sep 13, 2022
@oscargus oscargus deleted the moveaxesgridtests branch September 13, 2022 07:53
@rcomer rcomer mentioned this pull request Dec 9, 2022
Merged
6 tasks
rcomer pushed a commit to rcomer/matplotlib that referenced this pull request Dec 9, 2022
@ksunden @rcomer
Backport PR matplotlib#24677: FIX: do not replace the Axes._children …
fe900c5 
…list object

Manual backport due to conflicts, which were just additional tests in
main from matplotlib#23861, so simply removed these.
melissawm pushed a commit to melissawm/matplotlib that referenced this pull request Dec 19, 2022
@oscargus @melissawm
Move axes_grid tests to axes_grid1 (matplotlib#23861)
a4d2d81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees

No one assigned

Labels

Maintenance topic: mpl_toolkit topic: testing

Projects

None yet

Milestone

v3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@oscargus @QuLogic @timhoffm