Skip to content

Conversation

@QuLogic
Copy link
Member

@QuLogic QuLogic commented Aug 24, 2022

PR Summary

Due to the merging of matplotlib/mpl-sphinx-theme#26

PR Checklist

Tests and Styling

  • [n/a] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [n/a] New features are documented, with examples if plot related.
  • [n/a] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [n/a] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@QuLogic QuLogic added Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. labels Aug 24, 2022
@QuLogic QuLogic added this to the v3.6.0 milestone Aug 24, 2022
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can self-merge when docs build is green.

@QuLogic QuLogic merged commit 6471d4c into matplotlib:main Aug 25, 2022
@QuLogic QuLogic deleted the fix-theme-opt branch August 25, 2022 00:20
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 25, 2022
QuLogic added a commit that referenced this pull request Aug 25, 2022
…733-on-v3.6.x

Backport PR #23733 on branch v3.6.x (DOC: Update theme configuration for upcoming changes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants