Skip to content

Fix bug in Axes.bar_label(label_type='center') for non-linear scales. #23698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greglucas merged 3 commits into from
Sep 11, 2022
Merged

Fix bug in Axes.bar_label(label_type='center') for non-linear scales. #23698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d18d7d7
Implement solution from #23688 to properly center bar labels with dif…
stefmolin Aug 21, 2022
bb7fd69
Update center bar label test.
stefmolin Aug 22, 2022
5ffb34e
Add image comparison test.
stefmolin Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2712,7 +2712,13 @@ def sign(x):
value = extrema

if label_type == "center":
xy = xc, yc
xy = (0.5, 0.5)
kwargs["xycoords"] = (
lambda r, b=bar:
mtransforms.Bbox.intersection(
b.get_window_extent(r), b.get_clip_box()
)
)
else: # edge
if orientation == "vertical":
xy = xc, endpt
Expand Down
166 changes: 166 additions & 0 deletions ...atplotlib/tests/baseline_images/test_axes/test_centered_bar_label_nonlinear.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 12 additions & 2 deletions lib/matplotlib/tests/test_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7741,14 +7741,24 @@ def test_bar_label_location_center():
ys, widths = [1, 2], [3, -4]
rects = ax.barh(ys, widths)
labels = ax.bar_label(rects, label_type='center')
assert labels[0].xy == (widths[0] / 2, ys[0])
assert labels[0].xy == (0.5, 0.5)
assert labels[0].get_ha() == 'center'
assert labels[0].get_va() == 'center'
assert labels[1].xy == (widths[1] / 2, ys[1])
assert labels[1].xy == (0.5, 0.5)
assert labels[1].get_ha() == 'center'
assert labels[1].get_va() == 'center'


@image_comparison(['test_centered_bar_label_nonlinear.svg'])
def test_centered_bar_label_nonlinear():
_, ax = plt.subplots()
bar_container = ax.barh(['c', 'b', 'a'], [1_000, 5_000, 7_000])
ax.set_xscale('log')
ax.set_xlim(1, None)
ax.bar_label(bar_container, label_type='center')
ax.set_axis_off()


def test_bar_label_location_errorbars():
ax = plt.gca()
xs, heights = [1, 2], [3, -4]
Expand Down