Repository navigation
Api deprecate cmap functions - #23668
Merged
QuLogic merged 10 commits intoAug 20, 2022
Merged
Conversation
greglucas
reviewed
Aug 19, 2022
greglucas
left a comment
greglucas
left a comment
Contributor
There was a problem hiding this comment.
I will say, this looks like it will be noisy, but I think that it all makes everything much more explicit and readable IMO. So, overall I think it is a good direction.
tacaswell
force-pushed
the
api_deprecate_cmap_functions
branch
from
August 19, 2022 01:01
07d80fd to
396c88c
Compare
tacaswell
marked this pull request as ready for review
August 19, 2022 01:08
tacaswell
force-pushed
the
api_deprecate_cmap_functions
branch
2 times, most recently
from
August 19, 2022 01:15
418ee64 to
8f0c814
Compare
Member
Author
|
OK, really done force-pushing now... |
greglucas
approved these changes
Aug 19, 2022
greglucas
left a comment
greglucas
left a comment
Contributor
There was a problem hiding this comment.
👍 Good choice with the name of the private function, I think that is better.
QuLogic
reviewed
Aug 19, 2022
| fig, ax = plt.subplots() | ||
| ax.contourf(x, y, z, 7, hatches=['/', '\\', '//', '-'], | ||
| cmap=plt.get_cmap('gray'), | ||
| cmap=mpl.colormaps['gray'], |
Member
There was a problem hiding this comment.
Can we just use strings if we aren't using resample or using the Colormap for anything?
Member
Author
There was a problem hiding this comment.
It can, but I was just mechanically changing (a lot of this was done with search-and-relpace)
Member
Author
There was a problem hiding this comment.
I've decided to leave this. It makes the test a bit more complicated, but I do not know if we are definitely exercising the ability to pass Colormap objects through this top level API else where.
Member
Author
|
I'll try to get these changes in first thing tomorow morning, will not be offended if you want to push change @QuLogic . |
timhoffm
reviewed
Aug 19, 2022
tacaswell
force-pushed
the
api_deprecate_cmap_functions
branch
from
August 19, 2022 16:35
8f0c814 to
9321499
Compare
Member
Author
|
@timhoffm I think this is ready to review again. |
tacaswell
force-pushed
the
api_deprecate_cmap_functions
branch
from
August 19, 2022 17:43
9321499 to
ae90168
Compare
tacaswell
force-pushed
the
api_deprecate_cmap_functions
branch
from
August 19, 2022 20:11
e830ea7 to
093ee4a
Compare
timhoffm
reviewed
Aug 19, 2022
- matplotlib.cm.get_cmap - matplotlib.cm.register_cmap - matplotlib.cm.unregister_cmap - matplotlib.pyplot.register_cmap in preference for working with the ColormapRegistry on the top level module. Co-authored-by: Greg Lucas <greg.m.lucas@gmail.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Add it to the rendered docs.
tacaswell
force-pushed
the
api_deprecate_cmap_functions
branch
from
August 19, 2022 21:20
f51e784 to
a987e31
Compare
Member
Author
|
@timhoffm I think I got everything |
timhoffm
approved these changes
Aug 19, 2022
Member
|
Anybody can merge when green. |
QuLogic
approved these changes
Aug 20, 2022
This was referenced Aug 20, 2022
trexfeathers
added a commit
to trexfeathers/iris
that referenced
this pull request
Sep 28, 2022
pp-mo
pushed a commit
to SciTools/iris
that referenced
this pull request
Sep 28, 2022
* Change deprecated MPL colormap registration - matplotlib/matplotlib#23668. * Adapt benchmark for importing palette to cope with MPL 3.6. * What's New entry. * What's New typo. * Reformat import_iris imports.
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/niworkflows
that referenced
this pull request
Apr 17, 2024
matplotlib.cm.get_cmap → matplotlib.colormaps This is new in matplotlib 3.9: matplotlib/matplotlib#23668
DimitriPapadopoulos
added a commit
to DimitriPapadopoulos/niworkflows
that referenced
this pull request
Apr 17, 2024
matplotlib.cm.get_cmap → matplotlib.colormaps matplotlib/matplotlib#23668
effigies
pushed a commit
to nipreps/niworkflows
that referenced
this pull request
Apr 17, 2024
matplotlib.cm.get_cmap → matplotlib.colormaps matplotlib/matplotlib#23668 Fixes #865.
effigies
pushed a commit
to nipreps/niworkflows
that referenced
this pull request
Jun 10, 2024
matplotlib.cm.get_cmap → matplotlib.colormaps matplotlib/matplotlib#23668 Fixes #865.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This is my attempt to turn the crank on the depractions on the cm functions.
The changes were more extensive than I anticipated
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).