Skip to content

Fix issues in examples, docs, and tutorials - #23605

Merged
timhoffm merged 8 commits into
matplotlib:mainfrom
oscargus:examplesanddocs
Aug 14, 2022
Merged

timhoffm merged 8 commits into
matplotlib:mainfrom
oscargus:examplesanddocs

Conversation

@oscargus

Copy link
Copy Markdown
Member

PR Summary

Spent some time looking through the documentation tags and sort out a few.

Closes #8187
Closes #22746
Closes #23220
Adds examples to Artist methods
Use tick_params for a few more things.

PR Checklist

Tests and Styling

  • [N/A] Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).


The sequence is cycled for the levels in ascending order. If the sequence
is shorter than the number of levels, it's repeated.
is shorter than the number of levels, it is repeated.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really required. More a consequence of the other instance being incorrect.

ax.tick_params(axis='x', which='minor', tick1On=False, tick2On=False)

# Align the minor tick label
for label in ax.get_xticklabels(minor=True):

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is maybe not the best thing to loop over. But this is the method mentioned at the top, so from that perspective it makes more sense.

Comment thread tutorials/intermediate/artists.py Resolved
Comment thread doc/users/installing/index.rst Resolved
Comment thread examples/ticks/centered_ticklabels.py Resolved
Comment thread lib/matplotlib/tri/triangulation.py Resolved
@timhoffm timhoffm added this to the v3.6.0 milestone Aug 14, 2022
@timhoffm
timhoffm merged commit 6383e43 into matplotlib:main Aug 14, 2022
@oscargus
oscargus deleted the examplesanddocs branch August 14, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc]: Clarify offset parameter in linestyle [Doc]: Document that rcParams['font.family'] can be a list Axes doesn't have legends attribute?

2 participants