Repository navigation
Changing bar examples to tea and coffee - #23590
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
|
This looks good, except for the flake8 error. However, would you also be willing to do the same for the stacked bars as well? |
|
I will complete for the flake8 error and the stacked bars example too by 15th August 2022 @jklymak |
|
How to resolve this issue of ci/circleci: docs. I am facing this issue in both:
Can someone please help me out here |
|
There is no problem in those files; the problem is you need to rebase your branch on current |
|
When complete, this closes #23352 |
…d parkki_fish length
…d parkki_fish length
…d parkki_fish length
…d parkki_fish length
…d parkki_fish length
c5f98ec to
cf3733a
Compare
| ax.axhline(0, color='grey', linewidth=0.8) | ||
| ax.set_ylabel('Scores') | ||
| ax.set_title('Scores by group and gender') | ||
| ax.set_title('Scores by group and their beverage choices') |
There was a problem hiding this comment.
I just realized that the example has been semantically weird already before. The stacked bar suggests that the quantity is summed up from both subgroups, and the errorbar indicates that within each subgroup the quantity is averaged. I cannot come up with a reasonable quantity for "Scores" that would actually work this way.
Second, before there were groups and inside these groups we distinguished by gender. This is something everybody is familiar with. Splitting a group up by beverage choice and scoring these subgroups is possible but an even more weird experiment.
I think we have two choices:
a) Come up with something completely new
b) Or accept that the plot is not semantically meaningful, merge and do something a) later.
@story645 what do you think?
There was a problem hiding this comment.
Ugh, I want to be okay with merging something that's not semantically meaningful 'cause @SourajitaDewasi worked so much on this, but I hear you that the semantics being off might be a distraction that will make the example harder to follow.
Keeping it simple, maybe change the underlying pivot table to
(caffeinated, tea), (decaffeinated, tea), (caffeinated, coffee), (decaffeinated, coffee) and the y axis is like #avg drink rating (1-5) so the example is basically a made up rating of what type of drink folks prefer.
ETA: cup height probably works just as well, or average amount drunk or the like.
Alternatively, palmer penguins is being used a lot to illustrate aggregated visualizations, and we can probably keep this example pretty small if what we store in the example is the pivot table made from it https://allisonhorst.github.io/palmerpenguins/
There was a problem hiding this comment.
I would be fine with merging as-is as an improvement, with the suggestion below, and have a follow up either a) removing the example, or b) reworking it to include penguins or other good ideas.
There was a problem hiding this comment.
Ok, let's take this as is (suggestion below committed) so that we can git this in 3.6. And let's think about how we can further improve later.
|
@SourajitaDewasi thanks and congratulations on your first contribution to Matplotlib! 🎉 We hope to see you again. |
|
Thank you so much. This was my first contribution ever and this made me more eager to do better in OpenSource. I really look forward to working and contributing more in Matplotlib :) Thank you once again!!! |
* changing bar examples to tea and coffee * changing stacked bar examples to tea and coffee * changing stacked bar examples to tea and coffee * changing stacked bar examples to tea and coffee * changing barchart examples to tea and coffee * changing stacked bar examples to tea and coffee * changing barchart examples to tea and coffee * changing bar unit examples from men and women to bream_fish length and parkki_fish length * changing bar unit examples from men and women to bream_fish length and parkki_fish length * changing bar unit examples from men and women to bream_fish length and parkki_fish length * changing bar unit examples from men and women to bream_fish length and parkki_fish length * changing bar unit examples from men and women to bream_fish length and parkki_fish length * changing bar unit examples from men and women to coffee and tea cup size * changing bar unit examples from men and women to coffee and tea cup size * changing bar unit examples from men and women to coffee and tea cup size * changing bar unit examples from men and women to coffee and tea cup size * changing stacked bar examples to tea and coffee * changing bar unit from men and women to coffee and tea cup size * changing bar label examples from men and women to coffee and tea * changing bar label examples from men and women to coffee and tea * changing bar label examples from men and women to coffee and tea * changing bar label examples from men and women to coffee and tea * changing bar unit from men and women to coffee and tea cup size * Update examples/units/bar_unit_demo.py Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
* changing bar examples to tea and coffee * changing stacked bar examples to tea and coffee * changing stacked bar examples to tea and coffee * changing stacked bar examples to tea and coffee * changing barchart examples to tea and coffee * changing stacked bar examples to tea and coffee * changing barchart examples to tea and coffee * changing bar unit examples from men and women to bream_fish length and parkki_fish length * changing bar unit examples from men and women to bream_fish length and parkki_fish length * changing bar unit examples from men and women to bream_fish length and parkki_fish length * changing bar unit examples from men and women to bream_fish length and parkki_fish length * changing bar unit examples from men and women to bream_fish length and parkki_fish length * changing bar unit examples from men and women to coffee and tea cup size * changing bar unit examples from men and women to coffee and tea cup size * changing bar unit examples from men and women to coffee and tea cup size * changing bar unit examples from men and women to coffee and tea cup size * changing stacked bar examples to tea and coffee * changing bar unit from men and women to coffee and tea cup size * changing bar label examples from men and women to coffee and tea * changing bar label examples from men and women to coffee and tea * changing bar label examples from men and women to coffee and tea * changing bar label examples from men and women to coffee and tea * changing bar unit from men and women to coffee and tea cup size * Update examples/units/bar_unit_demo.py Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
* changing bar examples to tea and coffee * changing stacked bar examples to tea and coffee * changing stacked bar examples to tea and coffee * changing stacked bar examples to tea and coffee * changing barchart examples to tea and coffee * changing stacked bar examples to tea and coffee * changing barchart examples to tea and coffee * changing bar unit examples from men and women to bream_fish length and parkki_fish length * changing bar unit examples from men and women to bream_fish length and parkki_fish length * changing bar unit examples from men and women to bream_fish length and parkki_fish length * changing bar unit examples from men and women to bream_fish length and parkki_fish length * changing bar unit examples from men and women to bream_fish length and parkki_fish length * changing bar unit examples from men and women to coffee and tea cup size * changing bar unit examples from men and women to coffee and tea cup size * changing bar unit examples from men and women to coffee and tea cup size * changing bar unit examples from men and women to coffee and tea cup size * changing stacked bar examples to tea and coffee * changing bar unit from men and women to coffee and tea cup size * changing bar label examples from men and women to coffee and tea * changing bar label examples from men and women to coffee and tea * changing bar label examples from men and women to coffee and tea * changing bar label examples from men and women to coffee and tea * changing bar unit from men and women to coffee and tea cup size * Update examples/units/bar_unit_demo.py Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there). [N/A]doc/api/next_api_changes/(follow instructions in README.rst there). [N/A]cc: @jklymak