Skip to content

Change exception types, improve argument checking, and cleanups in mpl_toolkits #23550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QuLogic merged 4 commits into from
Aug 5, 2022
Merged

Change exception types, improve argument checking, and cleanups in mpl_toolkits #23550

QuLogic merged 4 commits into from
Aug 5, 2022

Conversation

@oscargus
Copy link
Member

@oscargus oscargus commented Aug 4, 2022 •
edited
Loading

PR Summary

Raise a more exact type.

Better argument checking.

Minor cleanups.

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus force-pushed the mpltoolkitcleanups branch 2 times, most recently from 00be652 to a95cf32 Compare August 4, 2022 09:44
@oscargus oscargus force-pushed the mpltoolkitcleanups branch from a95cf32 to 3e8c347 Compare August 4, 2022 11:03
@oscargus oscargus changed the title Change exception types and cleanups Change exception types, improve argument checking, and cleanups Aug 4, 2022
@oscargus oscargus changed the title Change exception types, improve argument checking, and cleanups Change exception types, improve argument checking, and cleanups in mpl_toolkits Aug 4, 2022
@oscargus oscargus marked this pull request as ready for review August 4, 2022 11:53
QuLogic
QuLogic reviewed Aug 4, 2022
View reviewed changes
lib/mpl_toolkits/axes_grid1/axes_divider.py
self._pos = pos
self._horizontal = horizontal
self._vertical = vertical
self._anchor = anchor
Copy link
Member

@QuLogic QuLogic Aug 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can drop this line now?

Copy link
Member Author

@oscargus oscargus Aug 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't some code quality tools complain if it is defined outside of __init__? That was the reason anyway.

@tacaswell tacaswell added this to the v3.6.0 milestone Aug 4, 2022
anntzer
anntzer reviewed Aug 4, 2022
View reviewed changes
@oscargus oscargus force-pushed the mpltoolkitcleanups branch from 3e8c347 to ad27ad7 Compare August 4, 2022 20:21
@oscargus oscargus force-pushed the mpltoolkitcleanups branch from ad27ad7 to e94dfed Compare August 4, 2022 21:22
@QuLogic QuLogic merged commit 80d79eb into matplotlib:main Aug 5, 2022
@oscargus oscargus deleted the mpltoolkitcleanups branch August 5, 2022 08:29
@dopplershift dopplershift mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anntzer anntzer anntzer approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees

No one assigned

Labels

API: changes Maintenance topic: mpl_toolkit

Projects

None yet

Milestone

v3.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@oscargus @QuLogic @anntzer @tacaswell