Repository navigation
Small cleanup to VertexSelector. - #23403
Merged
Merged
Conversation
Make the class picklable, by making `canvas` a property and using a picklable callback connect. Also some docstring fixes.
QuLogic
reviewed
Jul 8, 2022
| 'pick_event', self.onpick) | ||
| self.ind = set() | ||
|
|
||
| canvas = property(lambda self: self.axes.figure.canvas) |
Member
There was a problem hiding this comment.
Was there a reason we needed canvas in the first place?
Contributor
Author
There was a problem hiding this comment.
I would not have made this public to start with, but e.g. the HighlightSelector example (in the docstring) directly accesses it and it is marginally more convenient to have it there, so let's not bother with deprecating it?
timhoffm
approved these changes
Jul 11, 2022
timhoffm
left a comment
timhoffm
left a comment
Member
There was a problem hiding this comment.
canvas is de-facto public. Changing this to a property does not make it worse. We can always decide later whether we want to deprecate it.
QuLogic
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the class picklable, by making
canvasa property and using apicklable callback connect. Also some docstring fixes.
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).