Repository navigation
Remove ineffective exclusion of Arcs without parent Axes. - #23336
Merged
Merged
Conversation
QuLogic
reviewed
Jun 23, 2022
The `if not hasattr(self, 'axes'): raise RuntimeError(...)` check was ineffectual, as artists now always have an Axes attribute, which can just be None for some artists. In fact, small Arcs are drawn just fine without a parent Axes; e.g. ``` from pylab import * from matplotlib.patches import * fig = figure() fig.add_artist(Ellipse((.2, .2), .1, .3, angle=45)) # for comparison fig.add_artist(Arc((.2, .2), .1, .3, angle=45, theta1=0, theta2=45)) ``` works just fine. Remove the check, and adjust the docs accordingly. On the other hand, large arcs *did* previously fail, but that occurred a bit further down, when computing `transforms.BboxTransformTo(self.axes.bbox)` (`self.axes` is None --> AttributeError). Fix that by using the figure bbox in that case (as the point is to limit the drawing to the unclipped area, which is the whole figure for Arcs without a parent Axes).
oscargus
approved these changes
Jun 24, 2022
Member
|
I am surprised this has no tests. |
QuLogic
approved these changes
Jun 24, 2022
Member
|
I am pretty sure that the coverage error here is a false-negative and I believe this will be further tested by #23340 . |
Member
|
Test failures appear to all be the font issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
if not hasattr(self, 'axes'): raise RuntimeError(...)check wasineffectual, as artists now always have an Axes attribute, which can
just be None for some artists. In fact, small Arcs are drawn just fine
without a parent Axes; e.g.
works just fine. Remove the check, and adjust the docs accordingly.
On the other hand, large arcs did previously fail,
but that occurred a bit further down, when computing
transforms.BboxTransformTo(self.axes.bbox)(self.axesis None -->AttributeError). Fix that by using the figure bbox in that case (as the
point is to limit the drawing to the unclipped area, which is the whole
figure for Arcs without a parent Axes).
PR Summary
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).