Stairsplottype - #23311
Closed
kkoutris wants to merge 3 commits into
Closed
Stairsplottype#23311kkoutris wants to merge 3 commits into
kkoutris wants to merge 3 commits into
Conversation
jklymak
requested changes
Jun 21, 2022
jklymak
left a comment
jklymak
left a comment
Member
There was a problem hiding this comment.
Thanks for this!
OTOH I don't think we should have both stairs and steps. This should also be accompanied by a change to the cheatsheet if the stairs is really the preferred grammar here.
| if self.textposition == "inside": | ||
| r = s / np.interp(angle_span, [60, 90, 135, 180], | ||
| [3.3, 3.5, 3.8, 4]) | ||
| [10, 3.5, 11.4, 4]) |
Comment on lines
+2
to
+4
| ========== | ||
| stairs(x, y) | ||
| ========== |
Member
There was a problem hiding this comment.
Docs won't build if formatting is incorrect: /home/circleci/project/doc/plot_types/basic/stairs.rst:24: WARNING: Title overline too short.
Suggested change
| ========== | |
| stairs(x, y) | |
| ========== | |
| ============ | |
| stairs(x, y) | |
| ============ |
| ax.set(xlim=(0, 8), xticks=np.arange(1, 8), | ||
| ylim=(0, 8), yticks=np.arange(1, 8)) | ||
|
|
||
| plt.show() No newline at end of file |
Member
There was a problem hiding this comment.
We need the extra line for our linting.
jklymak
marked this pull request as draft
June 23, 2022 08:36
Member
|
I'll move to draft for now - feel free to move to ready when you have a chance to address.. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Added new plot type(stairs) to the documentation as asked by #23204.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).Add stairs plot type to the documentation as asked from [Doc]: More plot types? #23204