Skip to content

Fixed _upcast_err docstring and comments in _axes.py - #22923

Merged
QuLogic merged 1 commit into
matplotlib:mainfrom
andrew-fennell:fix-docstring
Apr 30, 2022
Merged

QuLogic merged 1 commit into
matplotlib:mainfrom
andrew-fennell:fix-docstring

Conversation

@andrew-fennell

@andrew-fennell andrew-fennell commented Apr 28, 2022 •

Copy link
Copy Markdown
Contributor

PR Summary

Addresses @efiring's concerns about the docstring and comments in #21884 (issue #21901).

Closes #21901

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • [N/A] New features are documented, with examples if plot related.
  • [N/A] New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • [N/A] API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus modified the milestones: v3.5-doc, v3.5.2 Apr 29, 2022
Comment thread lib/matplotlib/axes/_axes.py Resolved
Comment thread lib/matplotlib/axes/_axes.py Resolved
@andrew-fennell

Copy link
Copy Markdown
Contributor Author

@tacaswell I pushed updates to address your comments.

I saw #21901 was tagged as 3.5.2 and had been dormant for a while. I only realized that it was assigned to you after I had already made my changes. I hope it is okay that I worked on this.

Comment thread lib/matplotlib/axes/_axes.py Resolved
@tacaswell

Copy link
Copy Markdown
Member

I hope it is okay that I worked on this.

I do not mind at all!

@tacaswell tacaswell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tolerating my comments on this.

@andrew-fennell

Copy link
Copy Markdown
Contributor Author

Thank you for tolerating my comments on this.

I think it's better to correct it right now instead of needing to fix it later!

@QuLogic
QuLogic merged commit fabcc6b into matplotlib:main Apr 30, 2022
@QuLogic

QuLogic commented Apr 30, 2022

Copy link
Copy Markdown
Member

meeseeksdev backport to v3.5.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 30, 2022
QuLogic added a commit that referenced this pull request Apr 30, 2022
…923-on-v3.5.x

Backport PR #22923 on branch v3.5.x (Fixed _upcast_err docstring and comments in _axes.py)
@andrew-fennell
andrew-fennell deleted the fix-docstring branch April 30, 2022 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggested clarification of comments in errorbar helpers

4 participants