Repository navigation
Conversation
Member
|
How does this relate to #2263? I'm not sure what to do about the return value change. In principle it would break user code. In practice, there might be very little user code that uses the return value. |
Member
Author
|
gah, sorry about that. I need to make sure the spell-checker actually runs an I can convince my self that #2263 is both a good and bad idea, but it certainly conflicts with this branch. |
Member
|
The problem, as I see it, with #2263 is that it does something with Axis that should be handled in the Locator. Perhaps it makes sense to handle margins in the Locator, too... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #1912
Changes the api in a backwards compatible way on
Axes.set_xmargin,Axes.set_ymargin, andAxes3D.set_zmarginby adding an optional parameter.Changes api in non-backwards compatible way in the return value of
Axes.margins()(xmargin, ymargin)-> ((left, right), (bottom, top))and similar forAxes3D.margins()`.