Repository navigation
Added clim support to tripcolor - #22734
Merged
Merged
Conversation
Contributor
Author
|
I don't think randomness is encouraged in testing, but I am not very familiar with how to test some components. If anyone has any advice or suggestions, I would appreciate it! |
andrew-fennell
force-pushed
the
tripcolor-clim-support
branch
from
March 30, 2022 21:03
623e654 to
51fff64
Compare
timhoffm
reviewed
Mar 30, 2022
andrew-fennell
force-pushed
the
tripcolor-clim-support
branch
3 times, most recently
from
March 30, 2022 21:38
d6d0910 to
2e1033a
Compare
timhoffm
approved these changes
Mar 30, 2022
timhoffm
left a comment
Member
There was a problem hiding this comment.
Modulo one minor indentation issue.
andrew-fennell
force-pushed
the
tripcolor-clim-support
branch
from
March 30, 2022 22:02
2e1033a to
18ad350
Compare
Member
You've added a seed, so it is no longer "random"! |
jklymak
approved these changes
Mar 31, 2022
Member
|
Thanks @andrew-fennell ! |
davidgegiya
added a commit
to davidgegiya/agent-orchestrator
that referenced
this pull request
Nov 8, 2026
Pin a395083238625500dd3fa879e4976617d5353342 and its regression selectors for reproducible runs. Source: matplotlib/matplotlib#22734
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
tripcolor was ignoring
climinput.Added parameters to collection instantiations in tripcolor to ensure that all parameters are being handled properly (including
kwargs).Closes #22726
Example code:
Incorrect output
Correct output
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).