Skip to content

Small style fixes. - #22721

Merged
timhoffm merged 1 commit into
matplotlib:mainfrom
anntzer:style
Mar 29, 2022
Merged

timhoffm merged 1 commit into
matplotlib:mainfrom
anntzer:style

Conversation

@anntzer

@anntzer anntzer commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

PR Summary

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

Affine2D()
.scale(1.0, -1.0)
.translate(0.0, self.height))
return transform + Affine2D().scale(1, -1).translate(0, self.height)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The multi-line version is arguably more readable but not going to block over that.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+/-0

@tacaswell tacaswell added this to the v3.7.0 milestone Mar 28, 2022
Affine2D()
.scale(1.0, -1.0)
.translate(0.0, self.height))
return transform + Affine2D().scale(1, -1).translate(0, self.height)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+/-0

@timhoffm

Copy link
Copy Markdown
Member

@tacaswell you‘re milestoneing this as 3.7. have we already branched of 3.6?

Comment thread lib/matplotlib/legend.py Resolved
Comment thread lib/matplotlib/text.py Resolved
@timhoffm

Copy link
Copy Markdown
Member

We have not yet branched 3.6 off from main, so the canoncial target is 3.6.0.

@timhoffm
timhoffm merged commit ccf5115 into matplotlib:main Mar 29, 2022
@anntzer
anntzer deleted the style branch March 29, 2022 15:34
@tacaswell

Copy link
Copy Markdown
Member

I miss-clicked, but I did make the 3.7 milestone for stuff we know we want to push out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants