Skip to content

CI: try adding codeql - #22446

Closed
tacaswell wants to merge 3 commits into
mainfrom
tacaswell-patch-1
Closed

tacaswell wants to merge 3 commits into
mainfrom
tacaswell-patch-1

Conversation

@tacaswell

Copy link
Copy Markdown
Member

PR Summary

Enable static code analysis.

@tacaswell tacaswell added this to the v3.6.0 milestone Feb 10, 2022
@QuLogic

QuLogic commented Feb 11, 2022

Copy link
Copy Markdown
Member

Lots of alerts in FreeType and Qhull; might need to exclude them somehow. Though I haven't quite determined if any of them are actually 'high severity' for us.

@oscargus

Copy link
Copy Markdown
Member

I've checked some of the overflow warnings and it appears as if the risk of an actual overflow is quite limited. An option would be just to cast them to the higher precision type before multiplying. This will probably give a bit of a performance hit, but not clear how much.

(Seems like the life-time of the full reports are limited, I cannot see get directly to the source anymore.)

(Btw, did you change anything in the project settings? I tried this out for SymPy and it didn't run the check. Admittedly, we have a problem with one of our push tests, so maybe it would run if that passed, but still. When I created a PR from my own branch, it didn't run either and after instead adding it to the general test run-file, nothing rerun after force pushing changes...)

@tacaswell
tacaswell marked this pull request as draft March 25, 2022 03:30
@tacaswell

Copy link
Copy Markdown
Member Author

Anyone is more than welcome to take over this PR!

@timhoffm timhoffm modified the milestones: v3.6.0, unassigned Apr 30, 2022
Comment thread .github/workflows/codeql-analysis.yml Resolved
Comment thread .github/workflows/codeql-analysis.yml Resolved
Comment thread .github/workflows/codeql-analysis.yml Resolved
@oscargus

Copy link
Copy Markdown
Member

@oscargus oscargus mentioned this pull request Sep 4, 2022
@tacaswell

Copy link
Copy Markdown
Member Author

I'm going to close this and work from a branch on my fork.

I screwed up naming a file and do not feel comfortable force-pushing to upstream!

@tacaswell tacaswell closed this Sep 6, 2022
@tacaswell tacaswell mentioned this pull request Sep 6, 2022
@tacaswell
tacaswell deleted the tacaswell-patch-1 branch September 6, 2022 23:24
@QuLogic QuLogic added CI: testing CI configuration and testing status: superseded and removed status: orphaned PR labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: testing CI configuration and testing status: superseded

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants