Repository navigation
Bugfix in stackplot (Issue #22393): Removes artifacts when input height is zero #22424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3ff6d3b
FIX: Artifacts in stackplot if height of input is zero
tlkaufmann 61994eb
Added warning to stackplot for new parameter
tlkaufmann 8b3bfa6
fixed flake8 issues with stackplot.py
tlkaufmann c93a33d
DOC: fix doc markup
tacaswell 6ba0626
DOC: add whats new entry + versionaddd directive
tacaswell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| Suppress 0 thickness layers in stackplots | ||
| ----------------------------------------- | ||
|
|
||
| When making `.Axes.stackplot` where one of the layers is 0 it may or may not be | ||
| desirable for that layer to be visible. Using the new *where* keyword argument | ||
| along with the *interpolate* keyword argument these lines can be suppressed. | ||
|
|
||
|
|
||
| .. plot:: | ||
| :include-source: true | ||
|
|
||
| import matplotlib.pyplot as plt | ||
| import numpy as np | ||
|
|
||
| fig, (axl, axr) = plt.subplots(1, 2) | ||
|
|
||
| x = np.arange(10) | ||
|
|
||
| colors = ["grey", "blue", "red", "blue"] | ||
|
|
||
| y = np.stack( | ||
| [ | ||
| np.linspace(0, 1, 10), | ||
| np.linspace(0, 1, 10), | ||
| [0, 0, 0.25, 0, 0, 0, 0.25, 0, 0, 0], | ||
| np.linspace(0, 1, 10), | ||
| ] | ||
| ) | ||
|
|
||
| axl.set_title("No line") | ||
| axl.stackplot( | ||
| x, y, | ||
| colors=colors, edgecolor="face", | ||
| where=(y != 0), interpolate=True, | ||
| ) | ||
|
|
||
|
|
||
| axr.set_title("With line") | ||
| axr.stackplot( | ||
| x, y, | ||
| colors=colors, edgecolor="face", | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+7.05 KB
lib/matplotlib/tests/baseline_images/test_axes/stackplot_test_where.pdf
Binary file not shown.
Binary file added
BIN
+25.7 KB
lib/matplotlib/tests/baseline_images/test_axes/stackplot_test_where.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm struggling with the
whereparameter. While it is reasonable solve the issue internally by passingwheretofill_between, is there any reasonable value for where other thany!=0?whereneeds the shape ofy; i.e. must be 2D. Not having a resolution in x does not make sense. Using the same where array for all datasets should be the very exception; usually you need.It seems like a simpler high-level API such as a boolean parameter
clip_zero_regionsshould be enough, and that would internally usewhere=(y!=0).