Repository navigation
Make emit and auto args of set_{x,y,z}lim keyword only. - #22415
Merged
Merged
Conversation
timhoffm
approved these changes
Feb 6, 2022
timhoffm
added
the
API: changes
Member
|
Seems to break some internal callers. |
This should help with later improving argument checking in the setters, e.g. to make `set_xlim(3)` error out (requiring `set_xlim(left=3)`), as that is likely a logic error.
Contributor
Author
|
Hopefully fixed now. |
QuLogic
approved these changes
Feb 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This should help with later improving argument checking in the setters,
e.g. to make
set_xlim(3)error out (requiringset_xlim(left=3)), asthat is likely a logic error.
Goes on top of #21442 to avoid a rebase.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).