MNT: make layout deprecations pending#22345
Conversation
TST: fix the tests
30fef49 to
0f77ba9
Compare
|
Thanks! |
|
Should the api change now be adapted as well? |
|
Hmmm, I don't think I put in an API change note for the original deprecation, which was an oversight. |
|
So now that I think about this a bit more, do we really want to get rid of |
|
I'd definitively get rid of
|
|
OK, so left the pending deprecations in, but changed the deprecation note to say that set_tight/constrained_layout are discouraged rather than that they will be deprecated. |
PR Summary
Closes #22343
As noted there, deprecating immediately emits a DeprecationWarning, whereas this will emit a PendingDeprecationWarning.
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).